From 8e397e13d2e84e65eaa7398ce77a217bc51c4d77 Mon Sep 17 00:00:00 2001
From: Jannik <seil0@mosad.xyz>
Date: Thu, 22 Dec 2022 18:08:32 +0100
Subject: [PATCH] fix padding for ItemMedia

fixes missing shadows in light theme
---
 .../ui/activity/main/fragments/LibraryFragment.kt   |  1 -
 .../activity/main/fragments/MediaFragmentSimilar.kt |  3 +--
 app/src/main/res/layout/fragment_home.xml           | 13 +++++--------
 app/src/main/res/layout/fragment_library.xml        |  4 ++--
 app/src/main/res/layout/item_media.xml              |  6 ++----
 5 files changed, 10 insertions(+), 17 deletions(-)

diff --git a/app/src/main/java/org/mosad/teapod/ui/activity/main/fragments/LibraryFragment.kt b/app/src/main/java/org/mosad/teapod/ui/activity/main/fragments/LibraryFragment.kt
index 48a5343..0b4f264 100644
--- a/app/src/main/java/org/mosad/teapod/ui/activity/main/fragments/LibraryFragment.kt
+++ b/app/src/main/java/org/mosad/teapod/ui/activity/main/fragments/LibraryFragment.kt
@@ -34,7 +34,6 @@ class LibraryFragment : Fragment() {
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
 
-        binding.recyclerMediaLibrary.addItemDecoration(MediaItemDecoration(9))
         // TODO replace with pagination3
         // https://medium.com/swlh/paging3-recyclerview-pagination-made-easy-333c7dfa8797
         binding.recyclerMediaLibrary.addOnScrollListener(PaginationScrollListener())
diff --git a/app/src/main/java/org/mosad/teapod/ui/activity/main/fragments/MediaFragmentSimilar.kt b/app/src/main/java/org/mosad/teapod/ui/activity/main/fragments/MediaFragmentSimilar.kt
index ab65ab5..da9babb 100644
--- a/app/src/main/java/org/mosad/teapod/ui/activity/main/fragments/MediaFragmentSimilar.kt
+++ b/app/src/main/java/org/mosad/teapod/ui/activity/main/fragments/MediaFragmentSimilar.kt
@@ -47,8 +47,7 @@ class MediaFragmentSimilar : Fragment()  {
 
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
-
-        binding.recyclerMediaSimilar.addItemDecoration(MediaItemDecoration(9))
+        
         binding.recyclerMediaSimilar.adapter = MediaItemListAdapter(
             MediaItemListAdapter.OnClickListener {
                 activity?.showFragment(MediaFragment(it.id))
diff --git a/app/src/main/res/layout/fragment_home.xml b/app/src/main/res/layout/fragment_home.xml
index 7cf23e8..1993c9e 100644
--- a/app/src/main/res/layout/fragment_home.xml
+++ b/app/src/main/res/layout/fragment_home.xml
@@ -15,6 +15,7 @@
         <LinearLayout
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
+            android:layout_marginBottom="7dp"
             android:orientation="vertical">
 
             <com.facebook.shimmer.ShimmerFrameLayout
@@ -121,8 +122,7 @@
                 android:id="@+id/linear_up_next"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
-                android:orientation="vertical"
-                android:paddingBottom="7dp">
+                android:orientation="vertical">
 
                 <TextView
                     android:id="@+id/text_up_next"
@@ -169,8 +169,7 @@
                 android:id="@+id/linear_watchlist"
                 android:layout_width="match_parent"
                 android:layout_height="match_parent"
-                android:orientation="vertical"
-                android:paddingBottom="7dp">
+                android:orientation="vertical">
 
                 <TextView
                     android:id="@+id/text_watchlist"
@@ -265,8 +264,7 @@
                 android:id="@+id/linear_new_titles"
                 android:layout_width="match_parent"
                 android:layout_height="match_parent"
-                android:orientation="vertical"
-                android:paddingBottom="7dp">
+                android:orientation="vertical">
 
                 <TextView
                     android:id="@+id/text_new_titles"
@@ -313,8 +311,7 @@
                 android:id="@+id/linear_top_ten"
                 android:layout_width="match_parent"
                 android:layout_height="match_parent"
-                android:orientation="vertical"
-                android:paddingBottom="7dp">
+                android:orientation="vertical">
 
                 <TextView
                     android:id="@+id/text_top_ten"
diff --git a/app/src/main/res/layout/fragment_library.xml b/app/src/main/res/layout/fragment_library.xml
index c5943ca..be6b502 100644
--- a/app/src/main/res/layout/fragment_library.xml
+++ b/app/src/main/res/layout/fragment_library.xml
@@ -12,13 +12,13 @@
         android:layout_width="match_parent"
         android:layout_height="match_parent"
         android:clipToPadding="false"
-        android:padding="3dp"
         android:orientation="vertical"
+        android:padding="3dp"
+        app:layoutManager="androidx.recyclerview.widget.GridLayoutManager"
         app:layout_constraintBottom_toBottomOf="parent"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toTopOf="parent"
-        app:layoutManager="androidx.recyclerview.widget.GridLayoutManager"
         app:spanCount="@integer/item_media_columns"
         tools:listitem="@layout/item_media" />
 
diff --git a/app/src/main/res/layout/item_media.xml b/app/src/main/res/layout/item_media.xml
index 7b79e54..0b7fbf3 100644
--- a/app/src/main/res/layout/item_media.xml
+++ b/app/src/main/res/layout/item_media.xml
@@ -11,13 +11,11 @@
         android:backgroundTint="?themeSecondary"
         app:cardCornerRadius="7dp"
         app:cardElevation="4dp"
-        app:layout_constrainedWidth="true"
+        app:cardUseCompatPadding="true"
         app:layout_constraintBottom_toBottomOf="parent"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"
-        app:layout_constraintTop_toTopOf="parent"
-        app:layout_constraintWidth_default="percent"
-        app:layout_constraintWidth_percent="0.96">
+        app:layout_constraintTop_toTopOf="parent">
 
         <androidx.constraintlayout.widget.ConstraintLayout
             android:layout_width="match_parent"