Seil0/teapod
1
0
Fork 0
Code Issues 7 Pull Requests Releases 17 Wiki Activity

add dynamic spanCount for library/search fragemnt and MediaFragmentSimilar #68

Merged
Seil0 merged 3 commits from feature/dynamic_span_count into develop 2022-12-04 15:24:19 +01:00
Conversation 0 Commits 3 Files Changed 16
+226 -221
Seil0 commented 2022-12-03 00:11:35 +01:00
Owner
Copy Link
Copy Source

TODO

  • use percent for layout_constraintWidth_max in item_media.frame_image_progress (propably 45%)
  • set spanCount dynamically
    • LibraryFragment
    • SearchFragment
    • MediaFragmentSimilar

closes #31

### TODO * [x] use percent for layout_constraintWidth_max in item_media.frame_image_progress (propably 45%) * [x] set spanCount dynamically * LibraryFragment * SearchFragment * MediaFragmentSimilar closes #31
Seil0 added this to the 1.1.0 milestone 2022-12-03 00:11:35 +01:00
Seil0 added the enhancement label 2022-12-03 00:11:35 +01:00
Seil0 self-assigned this 2022-12-03 00:11:35 +01:00
Seil0 added 1 commit 2022-12-03 00:11:35 +01:00
update MediaItem to suport dynamic size 21caa8eb1b 
* this is needed for dynamic span count to correctly work
* this also fixes issues with poster image cropping when the MediaItem size was < 195dp
Seil0 added 1 commit 2022-12-04 13:51:52 +01:00
make MediaItem width fully dynamic, based on the parents width (50% of parent width) and update SearchFragment to use MediaItemListAdapter and remove now unused MediaItemAdapter fffbeaeb49
Seil0 added 1 commit 2022-12-04 14:48:32 +01:00
set spanCount according to screen width ed8f3fdcda
Seil0 marked the pull request as ready for review 2022-12-04 14:48:41 +01:00
Seil0 merged commit 81a20e0aa9 into develop 2022-12-04 15:24:19 +01:00
Seil0 deleted branch feature/dynamic_span_count 2022-12-04 15:24:19 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
ui/ux
UI/UX facing issue
 bug
Something is not working
 dependency
Issue(s) regarding a dependency
 downstream
Something regarding fdroid/google play/etc
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 p1
Issues with a high priority
 p2
Issues with a medium priority
p3
Issues with a low priority
 parser
A issue involving the AoDParser
 player
Things regarding the player
 question
More information is needed
 wontfix
This won't be fixed
No labels enhancement
Milestone
No items
No Milestone 1.1.0
Assignees
Clear assignees
Seil0 (Jannik)
No Assignees Seil0
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Seil0/teapod#68