diff --git a/prototype/src/main/java/org/hso/ecommerce/action/shop/CreateOrderAction.java b/prototype/src/main/java/org/hso/ecommerce/action/shop/CreateOrderAction.java index 854be3a..0102ced 100644 --- a/prototype/src/main/java/org/hso/ecommerce/action/shop/CreateOrderAction.java +++ b/prototype/src/main/java/org/hso/ecommerce/action/shop/CreateOrderAction.java @@ -13,6 +13,7 @@ import org.hso.ecommerce.entities.warehouse.WarehouseBookingPositionSlotEntry; import java.sql.Timestamp; import java.util.ArrayList; +import java.util.Comparator; import java.util.Date; import java.util.List; @@ -101,7 +102,14 @@ public class CreateOrderAction { for (OrderItem item : orderItems) { int needed = item.quantity; + // Sort for most empty slot first; + item.availableSlots.sort(Comparator.comparingInt(a -> a.newSumSlot)); + for (WarehouseBookingPositionSlotEntry slot : item.availableSlots) { + if (slot.newSumSlot == 0) { + continue; + } + int remove = Math.min(slot.newSumSlot, needed); needed -= remove;