From ffb683bdd0891ef6c376add65ea00b10e7595145 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lukas=20F=C3=BCrderer?= <l.fuerderer@gmail.com>
Date: Mon, 25 May 2020 17:19:25 +0200
Subject: [PATCH] Set the advertise flag if at least one supplier wants it to
 be set

---
 .../ecommerce/action/cronjob/UpdateOffersAction.java | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/prototype/src/main/java/org/hso/ecommerce/action/cronjob/UpdateOffersAction.java b/prototype/src/main/java/org/hso/ecommerce/action/cronjob/UpdateOffersAction.java
index 3046f2f..f095381 100644
--- a/prototype/src/main/java/org/hso/ecommerce/action/cronjob/UpdateOffersAction.java
+++ b/prototype/src/main/java/org/hso/ecommerce/action/cronjob/UpdateOffersAction.java
@@ -29,6 +29,12 @@ public class UpdateOffersAction {
 
     public List<ArticleOffer> finish() {
         HashMap<ArticleIdentifier, ArticleOffer> availableOffers = mapOffers();
+
+        // Reset all advertise-flags first. They are set again below.
+        for (ArticleOffer offer : availableOffers.values()) {
+            offer.shouldBeAdvertised = false;
+        }
+
         for (Entry<ArticleIdentifier, Offer> cheapestOffer : cheapestOffer.entrySet()) {
             String manufacturer = cheapestOffer.getKey().manufacturer;
             String articleNumber = cheapestOffer.getKey().articleNumber;
@@ -42,7 +48,11 @@ public class UpdateOffersAction {
             Article currentOfferedArticle = cheapestOffer.getValue().apiSupplier.findArticle(manufacturer,
                     articleNumber);
             currentOffer.vatPercent = currentOfferedArticle.vatPercent;
-            currentOffer.shouldBeAdvertised = currentOfferedArticle.shouldBeAdvertised;
+
+            // Set advertise-flag if any supplier wants it to be set
+            if (currentOfferedArticle.shouldBeAdvertised) {
+                currentOffer.shouldBeAdvertised = true;
+            }
         }
         return offers;
     }