From a72c0673b1f882cf30a0b38ec5321d943ea45f02cd2f549335df4ba0d80aa3c4 Mon Sep 17 00:00:00 2001 From: localhorst Date: Sat, 8 Feb 2025 20:05:14 +0100 Subject: [PATCH] Improve efficiency (#21) - Change to new One Wire Sensors that are no fakes - Increase chamber temperature Reviewed-on: https://git.mosad.xyz/localhorst/smart-oil-heating-control-system/pulls/21 Co-authored-by: localhorst Co-committed-by: localhorst --- main/control.c | 4 ++-- main/inputs.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/main/control.c b/main/control.c index cf62ec3..29a6295 100644 --- a/main/control.c +++ b/main/control.c @@ -12,7 +12,7 @@ #define RETURN_FLOW_TEMPERATURE_LOWER_LIMIT_DAY 30.0 #define RETURN_FLOW_TEMPERATURE_LOWER_LIMIT_NIGHT 25.0 -#define CHAMPER_TEMPERATURE_TARGET 70.0 +#define CHAMPER_TEMPERATURE_TARGET 80.0 #define BURNER_FAULT_DETECTION_THRESHOLD (60U * 3U) // Detect burner fault if after 3 minutes no burner start detected static const char *TAG = "smart-oil-heater-control-system-control"; @@ -98,7 +98,7 @@ void taskControl(void *pvParameters) if (bHeatingInAction == true) { - if (getChamberTemperature().fCurrentValue >= currentControlEntry.fChamberTemperature) + if ((getChamberTemperature().fCurrentValue >= currentControlEntry.fChamberTemperature) || (getChamberTemperature().predict60s.fValue >= currentControlEntry.fChamberTemperature)) { ESP_LOGI(TAG, "Chamber Target Temperature reached: Disable burner"); bHeatingInAction = false; diff --git a/main/inputs.c b/main/inputs.c index d9eb47f..62e7086 100644 --- a/main/inputs.c +++ b/main/inputs.c @@ -16,10 +16,10 @@ static const char *TAG = "smart-oil-heater-control-system-inputs"; const uint8_t uBurnerFaultPin = 19U; const uint8_t uDS18B20Pin = 4U; -const onewire_addr_t uChamperTempSensorAddr = 0x3e0000001754be28; -const onewire_addr_t uOutdoorTempSensorAddr = 0x880000001648e328; -const onewire_addr_t uInletFlowTempSensorAddr = 0xe59cdef51e64ff28; -const onewire_addr_t uReturnFlowTempSensorAddr = 0xa7a8e1531f64ff28; +const onewire_addr_t uChamperTempSensorAddr = 0xd00000108cd01d28; +const onewire_addr_t uOutdoorTempSensorAddr = 0x78000000c6c2f728; +const onewire_addr_t uInletFlowTempSensorAddr = 0x410000108b8c0628; +const onewire_addr_t uReturnFlowTempSensorAddr = 0x90000108cc77c28; onewire_addr_t uOneWireAddresses[MAX_DN18B20_SENSORS]; float fDS18B20Temps[MAX_DN18B20_SENSORS];