localhorst/e-commerce
Archived
4
1
Fork 0
Code Issues Pull Requests Releases 2 Wiki Activity

fix use Math.min for loopcount

Browse Source
This commit is contained in:
Hannes Huber 2020-05-10 17:25:48 +02:00
parent 530034a40e
commit edcdb2e9cf
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
prototype/src/main/java/org/hso/ecommerce/action/shop/GetRandomArticlesAction.java
View File

@ -9,7 +9,7 @@ public class GetRandomArticlesAction {
public static List<Article> getRandomArticles(int quantity, List<Article> advertisedArticles) { public static List<Article> getRandomArticles(int quantity, List<Article> advertisedArticles) {
List<Article> randomisedArticles = new ArrayList<Article>(); List<Article> randomisedArticles = new ArrayList<Article>();
int loopcount = quantity > advertisedArticles.size() ? advertisedArticles.size() : quantity; int loopcount = Math.min(quantity, advertisedArticles.size());
for (int i = 0; i < loopcount; i++) { for (int i = 0; i < loopcount; i++) {
int index = (int) (Math.random() * advertisedArticles.size()); int index = (int) (Math.random() * advertisedArticles.size());
randomisedArticles.add(advertisedArticles.remove(index)); randomisedArticles.add(advertisedArticles.remove(index));