localhorst/e-commerce
Archived
4
1
Fork 0
Code Issues Pull Requests Releases 2 Wiki Activity

feature/customers #58

Merged
Seil0 merged 8 commits from feature/customers into master 2020-06-12 00:52:54 +02:00
Conversation 3 Commits 8 Files Changed 3 +117 -127
hhuber commented 2020-06-10 18:45:23 +02:00
Collaborator
Copy Link
No description provided.
Seil0 added the
review
 label 2020-06-10 18:52:01 +02:00
Seil0 added a new dependency 2020-06-10 18:52:15 +02:00
#55 feature/cash_bookings
Seil0 commented 2020-06-10 19:28:14 +02:00
Collaborator
Copy Link

closes #36 closes #37

closes #36 closes #37
Seil0 requested changes 2020-06-11 14:45:02 +02:00
prototype/src/main/java/org/hso/ecommerce/controller/intern/customers/CustomersIndexController.java Outdated
@ -24,0 +38,4 @@
private final CustomerOrderRepository customerOrderRepository = null;
@Autowired
private final BookingRepository bookingRepository = null;
Seil0 commented 2020-06-11 14:41:43 +02:00
Collaborator

Kommt Doppelt vor.

Kommt Doppelt vor.
hhuber commented 2020-06-11 15:33:18 +02:00
Author
Collaborator

siehe 938d16301d

siehe 938d16301d
prototype/src/main/java/org/hso/ecommerce/controller/intern/customers/CustomersIndexController.java
@ -34,0 +58,4 @@
HttpServletResponse response,
HttpServletRequest request
) {
Optional<User> optUser = userRepository.findById(id);
Seil0 commented 2020-06-11 14:42:18 +02:00
Collaborator

Das userRepository fehlt.

Das userRepository fehlt.
hhuber commented 2020-06-11 15:33:08 +02:00
Author
Collaborator

siehe 938d16301d

siehe 938d16301d
Seil0 approved these changes 2020-06-12 00:52:50 +02:00
Seil0 left a comment
Collaborator

lgtm

lgtm
Seil0 closed this pull request 2020-06-12 00:52:54 +02:00
Seil0 deleted branch feature/customers 2020-06-12 00:53:00 +02:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Seil0
Labels
Clear labels
bug
Something is not working
dependencies
Update one or more dependencies
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
missing feature
A planned feature is missing
question
More information is needed
refactoring
Some Refactoring is needed
retest
review
Is under review
tschüss
ui
A ui specific issu or enhancement
wontfix
This won't be fixed
No Label
review
Milestone
No items
No Milestone
Assignees
Clear assignees
CodeSteak hhuber Lukas Seil0 localhorst
No Assignees
2 Participants
Due Date
No due date set.
Depends on
#55 feature/cash_bookings
localhorst/e-commerce
Reference: localhorst/e-commerce#58
No description provided.
Delete Branch "feature/customers"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?