feature/basic_functions #7
Reference in New Issue
Block a user
No description provided.
Delete Branch "feature/basic_functions"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Includes:
Shop/Articles
Shop/Mainpage
Shop/Checkout
Does not Include:
Tracking API
Shop/Search
@ -0,0 +9,4 @@public static List<Article> getRandomArticles(int quantity, List<Article> advertisedArticles) {List<Article> randomisedArticles = new ArrayList<Article>();int loopcount = quantity > advertisedArticles.size() ? advertisedArticles.size() : quantity;Replace with Math.min?
fixed
@ -154,0 +150,4 @@// @GetMapping("/privacy")// public String privacy() {// return "privacy";// }Wenn's nicht mehr gebraucht wird dann bitte raus damit.
Fixied in
777786f5b6@ -0,0 +12,4 @@@Overridepublic boolean preHandle(HttpServletRequest request, HttpServletResponse response, Object handler) throws Exception {Laut Intellij werden die Exceptions nie geworfen.
Ist wegen dem Interface, die Methode ist dort so deklariert. Daher würde ich das gerne so lassen, zwecks Konsistenz
Ok
@ -4,0 +20,4 @@import java.io.IOException;import java.io.InputStream;import java.util.ArrayList;import java.util.List;Unused Imports bitte entfernen.
@ -8,0 +39,4 @@HttpServletResponse response) {Unnötige Leerzeilen entfernen.
fixed
@ -2,1 +2,4 @@import org.hso.ecommerce.action.shop.GetRandomArticlesAction;import org.hso.ecommerce.entities.shop.Article;import org.hso.ecommerce.entities.user.User;Unused Import.
@ -30,0 +31,4 @@public BookingReason() {};Das kann auch weg.
Nope, ORM braucht nen leeren Konstruktor. Ich mach ein Kommentar drüber.
713c8ebe86Ich meinte auch das Semikolon.
@ -16,2 +14,3 @@private byte[] data;public String path;}Diese Leerzeile ist zu viel.
@ -18,3 +20,2 @@public int newSumArticles;public int newSumWarehousePosition;// Can;t do, does not work when created in action.; > '
removed
bd2aeb63f6@ -0,0 +1,6 @@INSERT INTO article_offers ("manufacturer", "article_number", "vat_percent")VALUES ("McDonalds", "1", 7);"should_be_advertised" fehlt hier.
@Hannes, your change
fixed it
Kann gemerged werden.