localhorst/e-commerce
Archived
4
1
Fork 0
Code Issues Pull Requests Releases 2 Wiki Activity

feature/basic_functions #7

Merged
Seil0 merged 30 commits from feature/basic_functions into master 2020-05-10 17:48:31 +02:00
Conversation 0 Commits 30 Files Changed 49 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit edcdb2e9cf - Show all commits

2
prototype/src/main/java/org/hso/ecommerce/action/shop/GetRandomArticlesAction.java
View File

@ -9,7 +9,7 @@ public class GetRandomArticlesAction {
public static List<Article> getRandomArticles(int quantity, List<Article> advertisedArticles) {
List<Article> randomisedArticles = new ArrayList<Article>();
int loopcount = quantity > advertisedArticles.size() ? advertisedArticles.size() : quantity;
int loopcount = Math.min(quantity, advertisedArticles.size());
Seil0 commented 2020-05-10 16:09:22 +02:00
Outdated
Review
Copy Link

Replace with Math.min?

Replace with Math.min?
hhuber commented 2020-05-10 17:25:24 +02:00
Review
Copy Link

fixed

fixed
for (int i = 0; i < loopcount; i++) {
int index = (int) (Math.random() * advertisedArticles.size());
randomisedArticles.add(advertisedArticles.remove(index));