rework burner fault detection

This commit is contained in:
Hendrik Schutter 2025-04-19 08:36:19 +02:00
parent 66b7f8320e
commit f66b831666

View File

@ -13,9 +13,9 @@
// Temperature thresholds // Temperature thresholds
#define RETURN_FLOW_TEMPERATURE_LOWER_LIMIT_DAY 30.0f #define RETURN_FLOW_TEMPERATURE_LOWER_LIMIT_DAY 30.0f
#define RETURN_FLOW_TEMPERATURE_LOWER_LIMIT_NIGHT 25.0f #define RETURN_FLOW_TEMPERATURE_LOWER_LIMIT_NIGHT 25.0f
#define CHAMBER_TEMPERATURE_TARGET 80.0f // Max cutoff temperature #define CHAMBER_TEMPERATURE_TARGET 80.0f // Max cutoff temperature
#define CHAMBER_TEMPERATURE_THRESHOLD 45.0f // Min threshold for burner enable #define CHAMBER_TEMPERATURE_THRESHOLD 45.0f // Min threshold for burner enable
#define OUTDOOR_TEMPERATURE_THRESHOLD 15.0f // Min threshold for burner enable #define OUTDOOR_TEMPERATURE_THRESHOLD 15.0f // Min threshold for burner enable
#define BURNER_FAULT_DETECTION_THRESHOLD (60U * 15U) // Burner fault detection after 15 minutes #define BURNER_FAULT_DETECTION_THRESHOLD (60U * 15U) // Burner fault detection after 15 minutes
static const char *TAG = "smart-oil-heater-control-system-control"; static const char *TAG = "smart-oil-heater-control-system-control";
@ -58,10 +58,17 @@ void initControl(void)
} }
} }
typedef enum _BurnerState
{
BURNER_UNKNOWN,
BURNER_FIRED,
BURNER_FAULT
} eBurnerState;
void taskControl(void *pvParameters) void taskControl(void *pvParameters)
{ {
bool bHeatingInAction = false; bool bHeatingInAction = false;
bool bBurnerFaultDetected = false; eBurnerState eBurnerState = BURNER_UNKNOWN;
int64_t i64BurnerEnableTimestamp = esp_timer_get_time(); int64_t i64BurnerEnableTimestamp = esp_timer_get_time();
while (1) while (1)
@ -116,20 +123,27 @@ void taskControl(void *pvParameters)
} }
else if (esp_timer_get_time() - i64BurnerEnableTimestamp >= BURNER_FAULT_DETECTION_THRESHOLD * 1000000U) else if (esp_timer_get_time() - i64BurnerEnableTimestamp >= BURNER_FAULT_DETECTION_THRESHOLD * 1000000U)
{ {
if (getBurnerError() == FAULT) if (eBurnerState == BURNER_UNKNOWN)
{ {
ESP_LOGW(TAG, "Burner fault detected after timeout!"); if (getBurnerError() == FAULT)
bHeatingInAction = false; {
bBurnerFaultDetected = true; ESP_LOGW(TAG, "Burner fault detected after timeout!");
sControlState = CONTROL_FAULT_BURNER; bHeatingInAction = false;
setCirculationPumpState(ENABLED); eBurnerState = BURNER_FAULT;
setBurnerState(DISABLED); sControlState = CONTROL_FAULT_BURNER;
setSafetyControlState(ENABLED); setCirculationPumpState(ENABLED);
setBurnerState(DISABLED);
setSafetyControlState(ENABLED);
}
else
{
eBurnerState = BURNER_FIRED;
}
} }
} }
} }
if (!bHeatingInAction && !bBurnerFaultDetected) if (!bHeatingInAction && (eBurnerState != BURNER_FAULT))
{ {
if (getOutdoorTemperature().average60s.fValue >= OUTDOOR_TEMPERATURE_THRESHOLD) if (getOutdoorTemperature().average60s.fValue >= OUTDOOR_TEMPERATURE_THRESHOLD)
{ {