Compare commits

..

No commits in common. "da7a1be183e9ca87a2a0170815e7d688e2f6d94fa07d1d07ee0690c1c0cb01e9" and "66b7f8320ef075afeae2c93722735d796443b8ba0c3c913f26628d6e1c71b101" have entirely different histories.

View File

@ -16,7 +16,7 @@
#define CHAMBER_TEMPERATURE_TARGET 80.0f // Max cutoff temperature
#define CHAMBER_TEMPERATURE_THRESHOLD 45.0f // Min threshold for burner enable
#define OUTDOOR_TEMPERATURE_THRESHOLD 15.0f // Min threshold for burner enable
#define BURNER_FAULT_DETECTION_THRESHOLD (60U * 4U) // Burner fault detection after 4 minutes
#define BURNER_FAULT_DETECTION_THRESHOLD (60U * 15U) // Burner fault detection after 15 minutes
static const char *TAG = "smart-oil-heater-control-system-control";
static eControlState sControlState = CONTROL_STARTING;
@ -58,17 +58,10 @@ void initControl(void)
}
}
typedef enum _BurnerState
{
BURNER_UNKNOWN,
BURNER_FIRED,
BURNER_FAULT
} eBurnerState;
void taskControl(void *pvParameters)
{
bool bHeatingInAction = false;
eBurnerState eBurnerState = BURNER_UNKNOWN;
bool bBurnerFaultDetected = false;
int64_t i64BurnerEnableTimestamp = esp_timer_get_time();
while (1)
@ -123,28 +116,20 @@ void taskControl(void *pvParameters)
}
else if (esp_timer_get_time() - i64BurnerEnableTimestamp >= BURNER_FAULT_DETECTION_THRESHOLD * 1000000U)
{
if (eBurnerState == BURNER_UNKNOWN)
if (getBurnerError() == FAULT)
{
if (getBurnerError() == FAULT)
{
ESP_LOGW(TAG, "Burner fault detected after threshold!");
bHeatingInAction = false;
eBurnerState = BURNER_FAULT;
sControlState = CONTROL_FAULT_BURNER;
setCirculationPumpState(ENABLED);
setBurnerState(DISABLED);
setSafetyControlState(ENABLED);
}
else
{
ESP_LOGW(TAG, "No Burner fault detected after threshold!");
eBurnerState = BURNER_FIRED;
}
ESP_LOGW(TAG, "Burner fault detected after timeout!");
bHeatingInAction = false;
bBurnerFaultDetected = true;
sControlState = CONTROL_FAULT_BURNER;
setCirculationPumpState(ENABLED);
setBurnerState(DISABLED);
setSafetyControlState(ENABLED);
}
}
}
if (!bHeatingInAction && (eBurnerState != BURNER_FAULT))
if (!bHeatingInAction && !bBurnerFaultDetected)
{
if (getOutdoorTemperature().average60s.fValue >= OUTDOOR_TEMPERATURE_THRESHOLD)
{
@ -158,7 +143,6 @@ void taskControl(void *pvParameters)
(getChamberTemperature().fCurrentValue <= CHAMBER_TEMPERATURE_THRESHOLD))
{
ESP_LOGI(TAG, "Enabling burner: Return flow temperature target reached");
eBurnerState = BURNER_UNKNOWN;
bHeatingInAction = true;
setCirculationPumpState(ENABLED);
setBurnerState(ENABLED);