Various improvements #17

Merged
Seil0 merged 11 commits from :fix/timeout-resilience into master 1 month ago
Collaborator

While this pull request also includes some small improvements, the main change can be found in the Timetable fixes commit.

As of now, the weekNumberYear didn't get updated through the scheduled updates. Also, if a timeout occurs on the scheduled update, the existing data is overwritten. I don't see a good reason for that. That's why I changed it accordingly.

While this pull request also includes some small improvements, the main change can be found in the Timetable fixes commit. As of now, the weekNumberYear didn't get updated through the scheduled updates. Also, if a timeout occurs on the scheduled update, the existing data is overwritten. I don't see a good reason for that. That's why I changed it accordingly.
hannesbraun added 7 commits 2 months ago
cf979df46e
Timetable fixes
c5916c65ae
Dependency updates
f98dc3d808
Small improvements
Owner

please rebase onto master

please rebase onto master
hannesbraun force-pushed fix/timeout-resilience from f98dc3d808 to 6f4cb9fd66 2 months ago
hannesbraun added 1 commit 2 months ago
e7b5eff04b
Use ConcurrentHashMap for timetableList
hannesbraun added 1 commit 2 months ago
235cc7f773
Limit sending timetable requests in parallel to 3
hannesbraun added 1 commit 2 months ago
Seil0 requested changes 1 month ago
val semaphore = Semaphore(3, 0)
}
private val htmlDoc: Document? =
Seil0 commented 1 month ago
Poster
Owner

please us ?.let { ... } for null safety. Something like this:

private val htmlDoc: Document? = htmlDoc ?: timetableURL?.let {
    runBlocking {
        ...
    }
}
please us `?.let { ... }` for null safety. Something like this: ```kotlin private val htmlDoc: Document? = htmlDoc ?: timetableURL?.let { runBlocking { ... } } ```
Poster
Collaborator

This should be fixed with ca14a5d2f6

This should be fixed with ca14a5d2f6
hannesbraun marked this conversation as resolved
hannesbraun added 1 commit 1 month ago
Seil0 approved these changes 1 month ago
Seil0 left a comment

lgtm

hannesbraun added 11 commits 1 month ago
22f17d10e0
Timetable fixes
a292b45fcb
Dependency updates
993b8f6a71
Small improvements
fb6291792d
Use ConcurrentHashMap for timetableList
8e3af696e0
Limit sending timetable requests in parallel to 3
Seil0 merged commit dc57a0d0c1 into master 1 month ago

Reviewers

Seil0 approved these changes 1 month ago
The pull request has been merged as dc57a0d0c1.
Sign in to join this conversation.
Loading…
There is no content yet.