Various improvements #17

hannesbraun · 2021-10-13T16:44:22+02:00

hannesbraun commented

2021-10-13 16:44:22 +02:00

While this pull request also includes some small improvements, the main change can be found in the Timetable fixes commit.

As of now, the weekNumberYear didn't get updated through the scheduled updates. Also, if a timeout occurs on the scheduled update, the existing data is overwritten. I don't see a good reason for that. That's why I changed it accordingly.

While this pull request also includes some small improvements, the main change can be found in the Timetable fixes commit. As of now, the weekNumberYear didn't get updated through the scheduled updates. Also, if a timeout occurs on the scheduled update, the existing data is overwritten. I don't see a good reason for that. That's why I changed it accordingly.

hannesbraun added 7 commits 2021-10-13 16:44:24 +02:00

Update Kotlin to 1.5.31 b4f7f48590

Timetable fixes cf979df46e

- Only one request is made to get the timetable HTML document for parsing the timetable and the weekNumberYear
- On timeouts or other errors, the cached data won't be overwritten with emptiness anymore
- The scheduled updates will now also update the weekNumberYear

Dependency updates c5916c65ae

This also replaces JCenter with Maven Central since JCenter is now read-only

Also set JVM target to 11 for Java f5ea292c6e

StatusController: use properties instead of getters 4e26a431cd

Make the update scheduling more readable (hopefully) 5d37c436ca

Small improvements f98dc3d808

- Improve formatting
- Fix some typos
- Mini code improvements

Seil0 commented

2021-10-13 19:51:12 +02:00

please rebase onto master

hannesbraun force-pushed fix/timeout-resilience from f98dc3d808 to 6f4cb9fd66

2021-10-13 22:22:22 +02:00

Compare

hannesbraun added 1 commit 2021-10-14 00:32:36 +02:00

Use ConcurrentHashMap for timetableList e7b5eff04b

Multiple requests may be processed at the same time and could otherwise cause problems (concurrent write operations)

hannesbraun added 1 commit 2021-10-15 20:08:11 +02:00

Limit sending timetable requests in parallel to 3 235cc7f773

Otherwise, the requests may fail (from my experience). Also we don't want to look suspicious (flooding their server with tons of requests at the same time).

hannesbraun added 1 commit 2021-10-16 01:08:59 +02:00

Only add timetable to cache on success 3d4e2f363d

Seil0 requested changes 2021-10-23 12:58:05 +02:00

src/main/kotlin/org/mosad/thecitadelofricks/hsoparser/TimetableParser.kt Outdated

						
				@ -35,0 +42,4 @@

				        val semaphore = Semaphore(3, 0)

				    }

				    private val htmlDoc: Document? =

Seil0 commented

2021-10-23 12:52:00 +02:00

please us ?.let { ... } for null safety. Something like this:

private val htmlDoc: Document? = htmlDoc ?: timetableURL?.let {
    runBlocking {
        ...
    }
}

please us `?.let { ... }` for null safety. Something like this: ```kotlin private val htmlDoc: Document? = htmlDoc ?: timetableURL?.let { runBlocking { ... } } ```

hannesbraun commented

2021-10-23 13:52:09 +02:00

This should be fixed with ca14a5d2f6

This should be fixed with ca14a5d2f6

hannesbraun marked this conversation as resolved

hannesbraun added 1 commit 2021-10-23 13:50:20 +02:00

Better null checks ca14a5d2f6

Seil0 approved these changes 2021-10-23 13:56:07 +02:00

Seil0 left a comment

lgtm

hannesbraun added 11 commits 2021-10-24 14:34:33 +02:00

Update Kotlin to 1.5.31 ae9bf2a562

Timetable fixes 22f17d10e0

- Only one request is made to get the timetable HTML document for parsing the timetable and the weekNumberYear
- On timeouts or other errors, the cached data won't be overwritten with emptiness anymore
- The scheduled updates will now also update the weekNumberYear

Dependency updates a292b45fcb

This also replaces JCenter with Maven Central since JCenter is now read-only

Also set JVM target to 11 for Java 90847a2730

StatusController: use properties instead of getters 460d1ee131

Make the update scheduling more readable (hopefully) f9cc9b5e14

Small improvements 993b8f6a71

- Improve formatting
- Fix some typos
- Mini code improvements

Use ConcurrentHashMap for timetableList fb6291792d

Multiple requests may be processed at the same time and could otherwise cause problems (concurrent write operations)

Limit sending timetable requests in parallel to 3 8e3af696e0

Otherwise, the requests may fail (from my experience). Also we don't want to look suspicious (flooding their server with tons of requests at the same time).

Only add timetable to cache on success ca8efdaa85

Better null checks 5ba9dfc263