Labels Milestones

Parse the year of a timetable #21

Merged

Seil0 merged 1 commits from :feature/parse-year into master 8 months ago

Conversation 0 Commits 1 Files Changed 4

hannesbraun commented 8 months ago

Collaborator

This adds the property year to the meta object returned in the timetable response.

Calculating the year of a course manually based on the current date and time is error prone as hell. Parsing should be a lot more error resistant. Although they're displaying a wrong year right now for the 52nd week... but it doesn't really matter around that time since there are no courses afaik.

This adds the property `year` to the meta object returned in the `timetable` response. Calculating the year of a course manually based on the current date and time is error prone as hell. Parsing should be a lot more error resistant. Although they're displaying a wrong year right now for the 52nd week... but it doesn't really matter around that time since there are no courses afaik.

hannesbraun added 12 commits 8 months ago

8ac78d29b1

Update Kotlin to 1.5.31

c62f576ace

Timetable fixes ...

- Only one request is made to get the timetable HTML document for parsing the timetable and the weekNumberYear
- On timeouts or other errors, the cached data won't be overwritten with emptiness anymore
- The scheduled updates will now also update the weekNumberYear

97efbd0877

Dependency updates ...

This also replaces JCenter with Maven Central since JCenter is now read-only

65dc8ea5d2

Also set JVM target to 11 for Java

b783fb6c4f

StatusController: use properties instead of getters

1f1374f112

Make the update scheduling more readable (hopefully)

6f4cb9fd66

Small improvements ...

- Improve formatting
- Fix some typos
- Mini code improvements

e7b5eff04b

Use ConcurrentHashMap for timetableList ...

Multiple requests may be processed at the same time and could otherwise cause problems (concurrent write operations)

235cc7f773

Limit sending timetable requests in parallel to 3 ...

Otherwise, the requests may fail (from my experience). Also we don't want to look suspicious (flooding their server with tons of requests at the same time).

3d4e2f363d

Only add timetable to cache on success

ca14a5d2f6

Better null checks

continuous-integration/woodpecker the build was successful

Details

24d0d9ac8c

TimetableParser: parse year ...

This also adds the parsed year to the meta object included in the timetable response

hannesbraun changed title from feature/parse-year to Parse the year of a timetable 8 months ago

hannesbraun requested review from Seil0 8 months ago

hannesbraun added the

enhancement

api

labels 8 months ago

hannesbraun added spent time 8 months ago

20min

hannesbraun force-pushed feature/parse-year from 24d0d9ac8c to d863f4fb1e 8 months ago

Seil0 approved these changes 8 months ago

Seil0 left a comment

Owner

lgtm

lgtm

Seil0 merged commit 940a30e9aa into master 8 months ago

Seil0 referenced this issue from a commit 8 months ago

Merge pull request 'Parse the year of a timetable' (#21) from hannesbraun/TheCitadelofRicks:feature/parse-year into master

Reviewers

Seil0 approved these changes 8 months ago

continuous-integration/woodpecker the build was successful

Details

The pull request has been merged as 940a30e9aa.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Seil0

Labels

Apply labels

Clear labels

api
API specific issue bug
Something is not working code/internal
A code specific issue duplicate
This issue or pull request already exists enhancement
New feature help wanted
Need some help hs issue
A issue or implementation difficulty that's part of the HS website invalid
Something is wrong planed
Planed for a further release question
More information is needed under investigation
Is under investigation wontfix
This won't be fixed

No Label api bug code/internal duplicate enhancement help wanted hs issue invalid planed question under investigation wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Total Time Spent: 20min

Hannes Braun

20min

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.