localhorst/e-commerce
Archived
4
1
Fork 0
Code Issues Pull Requests Releases 2 Wiki Activity

Implement Arrival of Supplier Order. #62

Merged
Seil0 merged 3 commits from feature/supplier_order_arrived_button into master 2020-06-13 11:59:18 +02:00
Conversation 5 Commits 3 Files Changed 8
+208 -49
CodeSteak commented 2020-06-12 19:23:33 +02:00
Collaborator
Copy Link
Copy Source
No description provided.
CodeSteak commented 2020-06-12 19:24:51 +02:00
Author
Collaborator
Copy Link
Copy Source

fixes #53

fixes #53
CodeSteak marked the pull request as work in progress 2020-06-12 19:41:06 +02:00
CodeSteak marked the pull request as ready for review 2020-06-12 19:50:37 +02:00
Lukas was assigned by CodeSteak 2020-06-12 19:58:51 +02:00
Seil0 was assigned by CodeSteak 2020-06-12 19:58:53 +02:00
localhorst was assigned by CodeSteak 2020-06-12 19:58:57 +02:00
localhorst commented 2020-06-12 20:37:16 +02:00
Owner
Copy Link
Copy Source

top!

top!
Seil0 added the review label 2020-06-12 21:41:22 +02:00
Seil0 requested changes 2020-06-13 10:12:42 +02:00
prototype/src/main/java/org/hso/ecommerce/controller/intern/suppliers/SupplierOrderController.java Outdated
@@ -50,2 +75,3 @@
System.out.println("Order is present\n");
final Article article = articleRepository.findArticleByArticleOffer(order.ordered).orElse(null);
if (order == null) {
Seil0 commented 2020-06-13 10:08:48 +02:00
Collaborator

In Zeile 64 gibt es doch schon ein if (order == null) mit einem return. Hab ich da was übersehen oder wird die Abfrage nie erfüllt?

In Zeile 64 gibt es doch schon ein `if (order == null)` mit einem return. Hab ich da was übersehen oder wird die Abfrage nie erfüllt?
CodeSteak commented 2020-06-13 11:55:49 +02:00
Author
Collaborator
Copy Link
Copy Source

Was a feature, not a bug. Removed in 7397698929

Was a feature, not a bug. Removed in 7397698929
Seil0 approved these changes 2020-06-13 11:59:11 +02:00
Seil0 left a comment
Collaborator

lgtm

lgtm
Seil0 closed this pull request 2020-06-13 11:59:18 +02:00
Seil0 deleted branch feature/supplier_order_arrived_button 2020-06-13 11:59:24 +02:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Seil0
Labels
Clear labels
bug
Something is not working
 dependencies
Update one or more dependencies
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 missing feature
A planned feature is missing
 question
More information is needed
 refactoring
Some Refactoring is needed
 retest
review
Is under review
 tschüss
ui
A ui specific issu or enhancement
 wontfix
This won't be fixed
No labels review
Milestone
No items
No Milestone
Assignees
Clear assignees
CodeSteak hhuber (Hannes Huber) Lukas Seil0 (Jannik) localhorst (Hendrik Schutter)
No Assignees Lukas Seil0 localhorst
3 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: localhorst/e-commerce#62