localhorst/e-commerce
Archived
4
1
Fork 0
Code Issues Pull Requests Releases 2 Wiki Activity

WIP feature/listedArticles #15

Merged
Seil0 merged 33 commits from feature/listedArticles into master 2020-05-15 19:48:22 +02:00
Conversation 2 Commits 33 Files Changed 10 +352 -120
localhorst commented 2020-05-14 23:02:53 +02:00
Owner
Copy Link
No description provided.
Seil0 was assigned by localhorst 2020-05-14 23:02:53 +02:00
Seil0 added the
review
 label 2020-05-15 14:07:13 +02:00
Seil0 requested changes 2020-05-15 19:41:38 +02:00
prototype/src/main/java/org/hso/ecommerce/app/RequestController.java Outdated
@ -115,6 +117,7 @@ public class RequestController {
public String internArticlesId() {
return "intern/articles/id";
}
*/
Seil0 commented 2020-05-15 19:34:28 +02:00
Collaborator

Auskommentiertes wenn möglich löschen

Auskommentiertes wenn möglich löschen
prototype/src/main/java/org/hso/ecommerce/controller/intern/InternArticleController.java Outdated
@ -8,0 +71,4 @@
// TODO img
String separatedCategories[] = categories.split("\n");
Seil0 commented 2020-05-15 19:35:58 +02:00
Collaborator

String[] separatedCategories

String[] separatedCategories
localhorst commented 2020-05-15 19:46:08 +02:00
Author
Owner

fixed with a98782bc01

fixed with https://git.mosad.xyz/localhorst/e-commerce/commit/a98782bc01fcdd03b746a9030539fc2bdf9301c4
prototype/src/main/java/org/hso/ecommerce/controller/intern/InternArticleController.java Outdated
@ -8,0 +238,4 @@
public long id;
public boolean shouldReorder;
public String warehouseUnitsPerSlot;
public String description;
Seil0 commented 2020-05-15 19:37:42 +02:00
Collaborator

Variablen Dekleration vor setter/getter? (Ich hab keine Ahnung ob wir da was ausgemacht haben)

Variablen Dekleration vor setter/getter? (Ich hab keine Ahnung ob wir da was ausgemacht haben)
localhorst commented 2020-05-15 19:43:30 +02:00
Author
Owner

ist ja ne ui model klasse die nur in diesem controller gebraucht wird. Wenn es keine Getter+Setter gibt werden die auch nicht gebraucht.

ist ja ne ui model klasse die nur in diesem controller gebraucht wird. Wenn es keine Getter+Setter gibt werden die auch nicht gebraucht.
Seil0 commented 2020-05-15 19:46:40 +02:00
Collaborator

Dann passt's so

Dann passt's so
localhorst commented 2020-05-15 19:47:52 +02:00
Author
Owner

fixed with b1840dd845

fixed with https://git.mosad.xyz/localhorst/e-commerce/commit/b1840dd84529acb8d4949913b35e1c1aea821b00
Seil0 approved these changes 2020-05-15 19:46:51 +02:00
Seil0 closed this pull request 2020-05-15 19:48:22 +02:00
Seil0 deleted branch feature/listedArticles 2020-05-15 19:48:26 +02:00
Seil0 removed the
review
 label 2020-05-26 19:29:22 +02:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Seil0
Labels
Clear labels
bug
Something is not working
dependencies
Update one or more dependencies
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
missing feature
A planned feature is missing
question
More information is needed
refactoring
Some Refactoring is needed
retest
review
Is under review
tschüss
ui
A ui specific issu or enhancement
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
CodeSteak hhuber Lukas Seil0 localhorst
No Assignees Seil0
2 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: localhorst/e-commerce#15
No description provided.
Delete Branch "feature/listedArticles"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?