Allow disabling subband seletion

include/TheThingsNetwork.h

@@ -203,7 +203,7 @@ public:
      * 
      * If not set, it defaults to sub-band 2 as defined by TTN.
      * 
-     * @param band band (between 1 and 8)
+     * @param band band (0 for all bands, or value between 1 and 8)
      */
     void setSubband(int band) { ttn_set_subband(band); }
 

include/ttn.h

@@ -198,7 +198,7 @@ void ttn_configure_pins(spi_host_device_t spi_host, uint8_t nss, uint8_t rxtx, u
  * 
  * If not set, it defaults to sub-band 2 as defined by TTN.
  * 
- * @param band band (between 1 and 8)
+ * @param band band (0 for all bands, or value between 1 and 8)
  */
 void ttn_set_subband(int band);
 

src/hal/hal_esp32.c

@@ -509,7 +509,7 @@ void hal_esp32_stop_lmic_task(void)
 
 static hal_failure_handler_t* custom_hal_failure_handler = NULL;
 
-void hal_set_failure_handler(const hal_failure_handler_t* const handler)
+void hal_set_failure_handler(hal_failure_handler_t* const handler)
 {
     custom_hal_failure_handler = handler;
 }

src/lmic/hal.h

@@ -133,7 +133,8 @@ void hal_failed (const char *file, u2_t line);
  * set a custom hal failure handler routine. The default behaviour, defined in
  * hal_failed(), is to halt by looping infintely.
  */
-void hal_set_failure_handler(const hal_failure_handler_t* const);
+void hal_set_failure_handler(hal_failure_handler_t* const);
+// ttn-esp32: too much const
 
 /*
  * get the calibration value for radio_rssi

src/ttn.c

@@ -211,7 +211,8 @@ bool join_core()
     waiting_reason = TTN_WAITING_FOR_JOIN;
 
 #if defined(CFG_us915) || defined(CFG_au915)
-    LMIC_selectSubBand(subband - 1);
+    if (subband != 0)
+        LMIC_selectSubBand(subband - 1);
 #endif
 
     LMIC_startJoining();

src/ttn_logging.c

@@ -50,7 +50,7 @@ typedef struct {
 } TTNLogMessage;
 
 static void loggingTask(void* param);
-static void logFatal(const char* file, uint16_t line);
+static void logFatal(const char* const file, const uint16_t line);
 
 static void printMessage(TTNLogMessage* log);
 static void printFatalError(TTNLogMessage* log);