localhorst/smart-oil-heating-control-system
SHA256
1
0
Fork 0
Code Issues 3 Pull Requests 3 Actions Packages Projects Releases 1 Wiki Activity

bugfix/static-code-analysis #28

Open
localhorst wants to merge 18 commits from bugfix/static-code-analysis into main
pull from: bugfix/static-code-analysis
merge into: localhorst:main
Conversation 1 Commits 18 Files Changed 7 +211 -96
localhorst commented 2026-01-10 12:03:14 +01:00
Owner
Copy Link

The claude.ai LLM performed a static code analysis.

The claude.ai LLM performed a static code analysis.
localhorst added the
bug
 label 2026-01-10 12:03:14 +01:00
localhorst self-assigned this 2026-01-10 12:03:14 +01:00
localhorst added 17 commits 2026-01-10 12:03:14 +01:00
Wrong memset size cd73985740
Off-by-one error (buffer overread) 0775fda0ca
Misuse of ESP_ERROR_CHECK 09a3c3a22d
ncorrect memset with strlen 781f9a1445
Missing mutex protection 267197ec20
Unprotected shared state access 8c3dbc2886
Non-thread-safe function df3825df3a
Unchecked gpio_config returns 10f9645580
Unchecked xEventGroupCreate 67929580d5
Unchecked network configuration 020eb63e05
Unchecked WiFi API call 05757a5038
Unsafe strcpy 0236ebcdd1
Floating-point equality comparison a9ec101bc6
uUnchangedCounter reset logic flaw 40f757b7d1
Variable name shadows type name d36b91a0fd
Missing break before default b718073907
Potential division by zero f3f6f1bc5f
localhorst added 1 commit 2026-01-25 15:00:25 +01:00
Merge branch 'main' into bugfix/static-code-analysis b6c27f049d
localhorst commented 2026-01-25 15:07:00 +01:00
Author
Owner
Copy Link

W (5263) smart-oil-heater-control-system-control: Control not possible due to SNTP fault! I (5403) wifi:<ba-add>idx:0 (ifx:0, 1c:56:8e:2c:67:30), tid:0, ssn:1, winSize:64 I (5673) smart-oil-heater-control-system-sntp: SNTP synchronization! Unix Time: 1769349911 E (16663) smart-oil-heater-control-system-control: Unable to take mutex: getControlState() E (26663) smart-oil-heater-control-system-control: Unable to take mutex: getControlCurrentTemperatureEntry() E (36663) smart-oil-heater-control-system-control: Unable to take mutex: getControlCurrentTemperatureEntry() E (46663) smart-oil-heater-control-system-control: Unable to take mutex: getControlCurrentTemperatureEntry() E (56663) smart-oil-heater-control-system-control: Unable to take mutex: getControlCurrentTemperatureEntry() E (68293) smart-oil-heater-control-system-control: Unable to take mutex: getControlState() E (78293) smart-oil-heater-control-system-control: Unable to take mutex: getControlCurrentTemperatureEntry()

`W (5263) smart-oil-heater-control-system-control: Control not possible due to SNTP fault! I (5403) wifi:<ba-add>idx:0 (ifx:0, 1c:56:8e:2c:67:30), tid:0, ssn:1, winSize:64 I (5673) smart-oil-heater-control-system-sntp: SNTP synchronization! Unix Time: 1769349911 E (16663) smart-oil-heater-control-system-control: Unable to take mutex: getControlState() E (26663) smart-oil-heater-control-system-control: Unable to take mutex: getControlCurrentTemperatureEntry() E (36663) smart-oil-heater-control-system-control: Unable to take mutex: getControlCurrentTemperatureEntry() E (46663) smart-oil-heater-control-system-control: Unable to take mutex: getControlCurrentTemperatureEntry() E (56663) smart-oil-heater-control-system-control: Unable to take mutex: getControlCurrentTemperatureEntry() E (68293) smart-oil-heater-control-system-control: Unable to take mutex: getControlState() E (78293) smart-oil-heater-control-system-control: Unable to take mutex: getControlCurrentTemperatureEntry()`
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin bugfix/static-code-analysis:bugfix/static-code-analysis
git checkout bugfix/static-code-analysis
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
localhorst
No Assignees localhorst
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: localhorst/smart-oil-heating-control-system#28
No description provided.
Delete Branch "bugfix/static-code-analysis"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?