Seil0/teapod
1
0
Fork 0
Code Issues 7 Pull Requests Releases 17 Wiki Activity

episodes/similar titles adapt to correct height #30

New Issue
Closed
opened 2021-02-06 19:05:14 +01:00 by Seil0 · 2 comments
Seil0 commented 2021-02-06 19:05:14 +01:00
Owner
Copy Link
Copy Source

Currently the viepager for episodes and similar titles does not adapt to the height of the current fragment/tab. This could be done using a CoordinateLayout.

Currently the viepager for episodes and similar titles does not adapt to the height of the current fragment/tab. This could be done using a CoordinateLayout.
Seil0 added this to the later milestone 2021-02-06 19:05:14 +01:00
Seil0 added the ui/uxp3 labels 2021-02-06 19:05:14 +01:00
Seil0 added the dependency label 2021-02-07 01:02:45 +01:00
Seil0 commented 2021-02-07 01:03:30 +01:00
Author
Owner
Copy Link
Copy Source

CoordinatorLayout has a bug which makes it unusable for our case at the moment. This problem can be worked around by increasing the offscreenPageLimit, wich should be fine as there are only two tabs.

See https://github.com/material-components/material-components-android/issues/1878

CoordinatorLayout has a bug which makes it unusable for our case at the moment. This problem can be worked around by increasing the offscreenPageLimit, wich should be fine as there are only two tabs. See https://github.com/material-components/material-components-android/issues/1878
Seil0 modified the milestone from later to 0.4.0 2021-02-07 01:14:43 +01:00
Seil0 self-assigned this 2021-02-07 01:14:46 +01:00
Seil0 commented 2021-02-08 00:25:02 +01:00
Author
Owner
Copy Link
Copy Source

This has been implemented with e762745705. Once the underlying material components bug has been fixed, the implemented workaround can be removed.

This has been implemented with e762745705. Once the underlying material components bug has been fixed, the implemented workaround can be removed.
Seil0 closed this issue 2021-02-08 00:25:02 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ui/ux
UI/UX facing issue
 bug
Something is not working
 dependency
Issue(s) regarding a dependency
 downstream
Something regarding fdroid/google play/etc
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 p1
Issues with a high priority
 p2
Issues with a medium priority
p3
Issues with a low priority
 parser
A issue involving the AoDParser
 player
Things regarding the player
 question
More information is needed
 wontfix
This won't be fixed
No labels ui/ux dependency p3
Milestone
No items
No Milestone 0.4.0
Assignees
Clear assignees
Seil0 (Jannik)
No Assignees Seil0
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Seil0/teapod#30