localhorst/reHDD
1
0
Fork 1
Code Issues 6 Pull Requests 2 Releases 10 Wiki Activity

bugfix/ai-static-analysis #82

Open
localhorst wants to merge 15 commits from bugfix/ai-static-analysis into master
pull from: bugfix/ai-static-analysis
merge into: localhorst:master
Conversation 2 Commits 15 Files Changed 5 +94 -66
localhorst commented 2025-12-07 19:12:37 +01:00
Owner
Copy Link

The claude.ai LLM performed a static code analysis.

The claude.ai LLM performed a static code analysis.
localhorst added 10 commits 2025-12-07 19:12:38 +01:00
Memory Leak in main.cpp 37cbc9500e
Memory Leak in Drive Scanning ff6a1763e0
Nullptr Return Without Proper Handling 2d63788352
Resource Leak - File Descriptor Not Checked bc4083a98c
Unchecked popen/pclose Return Values bcabad0620
Revert "Unchecked popen/pclose Return Values" eded3f166c 
This reverts commit bcabad0620.
Race Condition with Shared Drive List 46e8dae697
Integer Overflow in sprintf Buffer f303f9f032
Missing Error Check on time() Calls d82c45057b
Unchecked strerror() with Invalid Errno 4afc155230
localhorst reviewed 2025-12-07 19:12:59 +01:00
include/reHDD.h
@ -32,3 +32,3 @@
// Logic
// #define DRYRUN // don't touch the drives
#define DRYRUN // don't touch the drives
localhorst commented 2025-12-07 19:12:59 +01:00
Author
Owner
Copy Link

Revert before merge

Revert before merge
localhorst added 1 commit 2025-12-07 20:28:03 +01:00
Missing Bounds Check on Array Access c7d37b1d95
localhorst added 1 commit 2025-12-07 20:30:42 +01:00
Missing Validation of Pipe Return Value 2ca0b8b061
localhorst added 1 commit 2025-12-07 20:37:03 +01:00
Iterator Invalidation Bug 460cfeab2c
localhorst added 1 commit 2025-12-07 20:39:08 +01:00
fix terminate if no drive is detected 43ccdbd4d8
localhorst added 1 commit 2025-12-07 20:41:14 +01:00
Uninitialized Memory in cLine ba2f036d88
localhorst commented 2025-12-07 20:41:58 +01:00
Author
Owner
Copy Link

See attached report from claude.ai

See attached report from claude.ai
reHDD_code_analysis.md
20 KiB
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin bugfix/ai-static-analysis:bugfix/ai-static-analysis
git checkout bugfix/ai-static-analysis
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
refactor
you can do it better ;-)
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
localhorst
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: localhorst/reHDD#82
No description provided.
Delete Branch "bugfix/ai-static-analysis"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?